Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(layer-proj) - Better layer projection and extent densification support #2659

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feature(layer-proj) - Better layer projection and extent densification support #2659

merged 1 commit into from
Dec 13, 2024

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Dec 12, 2024 •
edited by jolevesq
Loading

Description

  • Improves support for layer projections once more.
  • Improves extent densification, to make sure the generated extent bbox adequately follows the curvature of the earth.

Fixes (partially? can't test well today, GeoCore service not working well) #2591

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Hosted Dec 13rd @ 13h30 : https://alex-nrcan.github.io/geoview/add-layers.html

NEED TO LOOK AT ISSUE, some uuid not working anymore

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@Alex-NRCan Alex-NRCan self-assigned this Dec 12, 2024
jolevesq
jolevesq requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

packages/geoview-core/src/geo/utils/projection.ts line 37 at r1 (raw file):

    LCC: 'EPSG:3978',
    3979: 'EPSG:3979',
    102100: 'EPSG:102100', // TODO: Minor - This is technically supposed to be ESRI:102100, but some things would need to change in order to support this, works now

What do you mean by this comment?

@Alex-NRCan Alex-NRCan force-pushed the feat-proj branch 4 times, most recently from d3a7b96 to 57c3821 Compare December 13, 2024 17:55
Alex-NRCan
Alex-NRCan commented Dec 13, 2024
View reviewed changes
Copy link
Member Author

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 3 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jolevesq)

packages/geoview-core/src/geo/utils/projection.ts line 37 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

What do you mean by this comment?

Done.

jolevesq
jolevesq approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2, 1 of 2 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

DamonU2
DamonU2 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 3 files at r2, 1 of 2 files at r3, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

@Alex-NRCan
Fixing extent densification
e527446 
Fixing the reading of WMS extents from a GetCapabilities call
Added support for projection EPSG:4269 and 102100
Tweaking Drop-Down-Button styling
jolevesq
jolevesq reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @Alex-NRCan and @DamonU2)

jolevesq
jolevesq approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r7.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

@jolevesq jolevesq merged commit 654878e into Canadian-Geospatial-Platform:develop Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamonU2 DamonU2 DamonU2 approved these changes

@jolevesq jolevesq jolevesq approved these changes

Assignees

@Alex-NRCan Alex-NRCan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-NRCan @jolevesq @DamonU2